-
Notifications
You must be signed in to change notification settings - Fork 645
[Backend Tester] Add slice and reshape tests #12851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12851
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 93 PendingAs of commit 0c873ab with merge base 64d8223 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming you have some way to figure out "how to test" in terms of coverage and which tests to add for these ops.
My methodology isn't super rigorous, but I am intending to cover all relevant portions of the user-facing torch API surface, under torch.nn, torch.nn.functional, and tensor ops. I've generated the list of ops to test from inspecting the docs: https://docs.pytorch.org/docs/stable/torch.html. I'm definitely open to suggestions. I prefer the user-facing surface over the core opset directly, in part because the wrapper modules can sometimes transform inputs in certain ways or enforce certain constraints that the backends often expect. Ideally, the backends would handle the full op-set space, but this was a common source of noise in the facto tests. The backend fails on some raw op inputs that cannot be generated through the nn.Module or similar. |
Add tests for a view-type ops, cat, and slice.