Fix CI build and improve parallelism #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
FindHao
changed the title
…rom install_cuda.sh. This change enhances the installation process by preserving environment variables and allowing for version-specific installations of cuDNN.
…This change modifies the argument passed to the install_cudnn function, enhancing compatibility with version specifications.
…ritonParse prerequisites. Removed optional test dependencies from pyproject.toml for clarity.
FindHao
force-pushed
the
findhao/remove_ci_job_dependency
branch
from
09575b0 to
a034481
Compare
…emove duplicate entry
…ditional CUDA installation for development libraries and ensured all necessary packages, including CUDA toolkit, are installed when required.
…tency in `README.md` regarding Triton installation instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two main improvements to the CI workflow:
Run Jobs in Parallel: The
testjob no longer waits for theformat-checkjob to complete. By removing theneedsdependency in.github/workflows/test.yml, both jobs can run concurrently, which helps to speed up the overall CI pipeline.Fix Broken cuDNN Installation: The CI was failing during the environment setup because the
install_cudnn.shscript from the PyTorch repository was removed. This has been fixed by:install_cuda.shscript which contains the necessaryinstall_cudnnfunction.install_cudnnfunction with the requiredCUDA_VERSIONandCUDNN_VERSIONarguments.These changes make the CI process both faster and more reliable.