[Ref Mode] PyTorch reference mode (eager only) #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
added a commit
that referenced
this pull request
Jul 20, 2025
stack-info: PR: #339, branch: yf225/stack/34
meta-cla
bot
added
the
CLA Signed
yf225
commented
Jul 20, 2025
helion/ref/hl_patch.py
Outdated
| ) | ||
|
|
||
| # Step 3: Handle block_size (in ref mode, full dim size is always used as block_size) | ||
| block_size_list = [None] * len(end_list) |
There was a problem hiding this comment.
Always use full dim size in ref modes regardless of block_size value
yf225
commented
Jul 20, 2025
yf225
commented
Jul 20, 2025
test/test_ref_compile.py
Outdated
| class TestExamplesRefCompile(test_examples.TestExamples): | ||
| """Run all TestExamples tests in reference torch.compile mode via HELION_REF_COMPILE=1.""" | ||
|
|
||
| # NOTE: All tests in TestExamples are run in ref torch.compile(fullgraph=True) mode by default in this test file. |
There was a problem hiding this comment.
Currently all examples in TestExamples pass with ref eager mode and ref compile mode.
Planning to add more ref mode unit tests to cover test_reduce.py, test_associative_scan.py etc. in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[Ref Mode] PyTorch reference mode (eager only)
Part of #77.
Please see inline code comments on the PR.