Rework / remove method reload_page #4602
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorjMcKie
force-pushed
the
use-sync-page
branch
2 times, most recently
from
0924dc1 to
32d4d54
Compare
We previously refreshed a Page in memory by simulating navigating away to another page and returning. This has been necessary after certain updates or inserts of annotations and links. This fix basically replaces it with the feature provided by mupdf function pdf_sync_page(), which is now what Page method refresh() does. This is a tentative update yet: As MuPDF propagates calling pdf_sync_page(9 over time, we should reduce and eventually retire Page.refresh() and Document.reload_page().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously refreshed a Page in memory by simulating navigating away to another page and returning. This has been necessary after certain updates or inserts of annotations and links. This fix basically replaces it with the feature provided by mupdf function pdf_sync_page(), which is now what Page method refresh() does.
This is a tentative update yet: As MuPDF propagates calling pdf_sync_page() over time, we should reduce and eventually retire Page.refresh() and Document.reload_page().