Fix implementation of the structure prior term of the BDeu score #248
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Bernoulli edge-based structure prior combined with the BDeu marginal likelihood, the structure prior can be written as
where$d$ denotes the number of variables (features), since each node can have at most $d-1$ possible parents.
In the original implementation, however, the
Dataarray has shape(number_of_samples, number_of_variables). Therefore,Data.shape[1]should be used instead ofData.shape[0]when computing the structure prior.