Ensure database connections are always closed #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are merge conflicts and the DCO is missing. |
Yes you're right Joe. This is again an attempt to upstream some changes from grafana/postgres_exporter. It's one of those small changes that should be easy to get in a good shape. I'm leaving it with @dehaansa to rebase the original branch and sign the DCO as he's the author (hence the PR is still in draft). |
Signed-off-by: Sam DeHaan <sam.dehaan@grafana.com>
dehaansa
force-pushed
the
fix/close-everything
branch
from
6c034b2 to
743b06f
Compare
Signed-off-by: Sam DeHaan <dehaansa@gmail.com>
|
I've signed & merged, I believe it's all correct now but I don't have spare capacity right now to deeply test. Will watch for CI issues. |
|
Thanks! Marked as ready for review now. |
sysadmind
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change authored by @dehaansa in grafana#23