Skip to content

Conversation

vhsu14
Copy link
Contributor

@vhsu14 vhsu14 commented Sep 26, 2025

Summary: Update connector functions to match facebookincubator/velox#14950

Differential Revision: D83300734

Summary: Update connector functions to match facebookincubator/velox#14950

Differential Revision: D83300734
@vhsu14 vhsu14 requested review from a team as code owners September 26, 2025 09:26
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Sep 26, 2025
Copy link
Contributor

sourcery-ai bot commented Sep 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Align connector runtimeStats implementations with upstream Velox changes by replacing per-driver RuntimeCounter metrics with per-call RuntimeMetric in SystemConnector and ArrowFlightConnector.

File-Level Changes

Change Details Files
Switch runtimeStats return type to RuntimeMetric for connectors
  • Modify SystemConnector::runtimeStats signature to return unordered_map<string, RuntimeMetric>
  • Modify ArrowFlightConnector::runtimeStats signature to return unordered_map<string, RuntimeMetric>
presto-native-execution/presto_cpp/main/connectors/SystemConnector.h
presto-native-execution/presto_cpp/main/connectors/arrow_flight/ArrowFlightConnector.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@facebook-github-bot
Copy link
Collaborator

@vhsu14 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83300734.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants