Add Creditcoin3 support to Generic Ledger App

[salina-dev]

Add Creditcoin3 support to Generic Ledger App

[valentinfernandez1]

Are there any updated about this Draft PR?

[DylanVerstraete]

@valentinfernandez1 please check 👍 😄

[TarikGul]

🚀

[TarikGul]

Apologies for the early approval - believe inside of hw-ledger/src/defaults.ts creditcoin3 should be under genericLedgerApps instead

[TarikGul]

Just needs a yarn lint

[beqaabu]

@TarikGul, we dont want to enable ledger support on mainnet before testing it on our testnet first, but the note in genesis.ts says:

// IMPORTANT: Apart from the test relays, this list is limited to live parachains
// and live production networks. It does not and should not contain any testnets,
// either stand-alone or connected to test relays such as Westend/Rococo

see the link: https://github.com/gluwa/common/blob/ab1d3c0b07bd79cf8aab937ad22e5df4b68e78ba/packages/networks/src/defaults/genesis.ts#L11-L13
We have made necessary changes on the protocol level to support ledger, but without the changes in this pr our ledger support page looks like this

instead of this

As you can see, there is no option to attach ledger, which is expected. Could you please suggest how we could achieve what we want without violating the note given above?

[beqaabu]

Hi @TarikGul @valentinfernandez1, could you please take a look?