Staking Async Feedback

[ap211unitech]

📝 Description

This PR addresses the feedback outlined in this issue. Below is an overview of the updated changes.

[kianenigma]

I think you are still parsing the snapshot range wrong. It should have a value like:

• None if Phase::None
• 31 -> 15 (when we are for example in Phase::Snapshot(14)),
• and 31 -> 0 in all other phases

This should always be the first and last item in this list: https://github.com/paritytech/polkadot-scripts/blob/51a99829460322be11379ea642f0642940604b1a/src/handlers.ts#L253C25-L254C15

[ap211unitech]

Hi @kianenigma , I'm fetching it like this:

const snapshotRange = (
      await ahApi.query.multiBlockElection.pagedVoterSnapshotHash.entries()
    )
      .map(([k]) => k.args[0])
      .sort();

console.log(snapshotRange.map((a) => a.toHuman()));

and I am already rendering first and last item in list:

const uniquePages = Array.from(new Set(snapshotRange.map((p) => Number(p.toString())))).sort((a, b) => a - b);
const [minPage, maxPage] = [uniquePages[0], uniquePages[uniquePages.length - 1]];

The script you provided seems to fetch it the same way. Could you please clarify what I might be doing wrong?

[kianenigma]

I think it is likely because pagedVoterSnapshotHash is now a double map of (u32, u32) ((round, page_index)), and we are interested in page_index, so you should use k.args[1].

[ap211unitech]

I think it is likely because pagedVoterSnapshotHash is now a double map of (u32, u32) ((round, page_index)), and we are interested in page_index, so you should use k.args[1].

Updated it now (and attached image as well)

[ap211unitech]

Hi @kianenigma, When you have a moment, could you please provide your go-ahead so we can proceed with the review?