Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

Opt move cookie init to backend and add optional ignore connection error #14

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

elwinarens
Copy link
Contributor

@elwinarens elwinarens commented Jun 22, 2018

Work In Progress (WIP). Would like to add unit tests, but have confirmed this is working locally.

The current setup does a few things different:

  • Fetching of the cookie config is moved to the part where the user authenticates with the backend, iff the config is None.
  • A connection error exception can be optionally ignored by setting CROWD_RAISE_CONNECTION_ERROR to False. By default an exception is thrown, adhering to the request by you to not have a change in behaviour by default. The result will be that the user can no longer authenticate and will be logged out once the cookie/token is expired.

Happy to hear your thoughts

@bellarc
Copy link

bellarc commented Jan 24, 2019

@elwinarens has the owner of this repo acknowledged this change? I wonder if @pmuller is still maintaining this project at this point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants