Disable checkstyle MissingSwitchDefault rule #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Rather than a warning, shouldn't we completely remove the We may also want to consider adding |
adangel
added a commit
to adangel/build-tools
that referenced
this pull request
Sep 12, 2025
- ExhaustiveSwitchHasDefault (refs pmd#98) - RelianceOnDefaultCharset - ModifierOrder - DanglingJavadoc - CollectionTypeMismatch - OverrideBothEqualsAndHashCodeOnComparable
This was referenced Sep 12, 2025
|
I think, we should remove this checkstyle rule completely and not even create a warning (who looks at warnings if they don't fail the build?) We have already our PMD rule NonExhaustiveSwitch enabled and #99 adds ExhaustiveSwitchHasDefault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check caused a checkstyle failure on pmd/pmd#6037 even though the switch is exhaustive