PMM-13513: add support for cleartext passwords #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
requested review from
BupycHuk,
JiriCtvrtka and
ademidoff
and removed request for
a team
ademidoff
approved these changes
Jul 29, 2025
config/config.go
Outdated
| SslKey string `ini:"ssl-key"` | ||
| TlsInsecureSkipVerify bool `ini:"ssl-skip-verfication"` //nolint:misspell | ||
| Tls string `ini:"tls"` | ||
| EnableCleartextPassword bool `ini:"enable-cleartext-plugin"` |
There was a problem hiding this comment.
Suggested change
| EnableCleartextPassword bool `ini:"enable-cleartext-plugin"` | |
| EnableCleartextPlugin bool `ini:"enable-cleartext-plugin"` |
IMO, we can leave it as is for naming consistency.
There was a problem hiding this comment.
Just checked the code in the monorepo and I now see the point in renaming :)
config/config.go
Outdated
| @@ -208,6 +209,9 @@ func (m MySqlConfig) FormDSN(target string) (string, error) { | |||
| config.TLSConfig = "custom" | |||
| } | |||
| } | |||
| if m.EnableCleartextPassword { | |||
There was a problem hiding this comment.
Suggested change
| if m.EnableCleartextPassword { | |
| if m.EnableCleartextPlugin { |
There was a problem hiding this comment.
Yeah, I can definitely change it - just went with password because that's what the field is called in the package-level Config.
JiriCtvrtka
approved these changes
Jul 29, 2025
BupycHuk
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.