Skip to content

PMM-13881 Fix incorrect git describe behavior in Makefile #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

BupycHuk
Copy link
Member

@BupycHuk BupycHuk commented May 1, 2025

Updated the COMPONENT_VERSION variable to use --tags flag with git describe to ensure proper tagging is captured. This ensures the build process correctly identifies version tags over lightweight commits.

PMM-13881 (optional, if ticket reported)

  • Links to related pull requests (optional).

Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

Updated the COMPONENT_VERSION variable to use `--tags` flag with `git describe` to ensure proper tagging is captured. This ensures the build process correctly identifies version tags over lightweight commits.
@BupycHuk BupycHuk requested a review from a team as a code owner May 1, 2025 11:49
@BupycHuk BupycHuk requested review from ademidoff and JiriCtvrtka and removed request for a team May 1, 2025 11:49
@BupycHuk BupycHuk enabled auto-merge (squash) May 1, 2025 14:35
@BupycHuk BupycHuk disabled auto-merge May 5, 2025 09:55
@BupycHuk BupycHuk merged commit bb7ecc3 into main May 5, 2025
13 checks passed
@BupycHuk BupycHuk deleted the PMM-13881_mongodb_exporter_version_fix branch May 5, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants