Skip to content

Fix Assistant exception with OpenAI #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Assistant exception with OpenAI #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a632a03
[SECURITY] Update cohere-ruby requirement from ~> 0.9.10 to ~> 1.0.1 …
dependabot[bot] Jun 11, 2025
ed6e3fb
Use `public_send` instead of `send` (#996)
koic Jun 11, 2025
a6a3521
Fix OpenAI assistant tools call issue
littlechu Jul 8, 2025
a76bab7
Merge branch 'patterns-ai-core:main' into fix_openai_tools_call
littlechu Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/langchain/assistant.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ def handle_user_or_tool_message
end

def set_state_for(response:)
if response.tool_calls.any?
if response.tool_calls&.any?
:in_progress
elsif response.chat_completion
:completed
Expand Down
3 changes: 2 additions & 1 deletion lib/langchain/assistant/llm/adapters/openai.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def build_chat_params(
# @param tool_calls [Array] The tool calls
# @param tool_call_id [String] The tool call ID
# @return [Messages::OpenAIMessage] The OpenAI message
def build_message(role:, content: nil, image_url: nil, tool_calls: [], tool_call_id: nil)
def build_message(role:, content: nil, image_url: nil, tool_calls: nil, tool_call_id: nil)
tool_calls ||= []
Messages::OpenAIMessage.new(role: role, content: content, image_url: image_url, tool_calls: tool_calls, tool_call_id: tool_call_id)
end

Expand Down