Skip to content

feat: Add support for Parse.Query.include in LiveQuery #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: alpha
Choose a base branch
from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 17, 2025

Pull Request

Issue

Add support for Parse.Query.include in LiveQuery. Requires a Parse Server version that also supports this, see parse-community/parse-server#9827.

Approach

Pass include param on to server.

Summary by CodeRabbit

  • New Features

    • Added support for handling the include field in live query subscriptions, allowing related data to be included in real-time updates.
  • Tests

    • Updated tests to verify correct handling of the include field in live query subscription payloads.

Copy link

parse-github-assistant bot commented Jul 17, 2025

🚀 Thanks for opening this pull request!

Copy link

coderabbitai bot commented Jul 17, 2025

Warning

Rate limit exceeded

@mtrezza has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9656a66 and f950fb1.

📒 Files selected for processing (2)
  • src/LiveQueryClient.ts (5 hunks)
  • types/LiveQueryClient.d.ts (1 hunks)
📝 Walkthrough

Walkthrough

Support for the include field in query JSON has been added to the LiveQueryClient class. The include property is now extracted, converted to an array, and included in subscription requests. Corresponding test cases have been updated to construct queries with include and assert its presence in the subscription payloads.

Changes

File(s) Change Summary
src/LiveQueryClient.ts Added logic to extract and include the include array from query JSON in subscription requests.
src/tests/LiveQueryClient-test.js Updated tests to use query.include(['key']) and verify include in subscription payloads.

Sequence Diagram(s)

sequenceDiagram
    participant Client as LiveQueryClient
    participant Server as LiveQuery Server

    Client->>Client: Parse query JSON, extract 'include'
    Client->>Server: Send subscription request with query (includes 'include' array)
    Server-->>Client: Acknowledge subscription or send data
Loading
sequenceDiagram
    participant Test as Test Suite
    participant Client as LiveQueryClient
    participant Server as Mock WebSocket

    Test->>Client: Construct ParseQuery with include(['key'])
    Client->>Server: Send subscription payload (contains include: ['key'])
    Test->>Server: Assert payload includes 'include' field
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jul 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5aa45b1) to head (f950fb1).

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2694   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6185      6187    +2     
  Branches      1456      1456           
=========================================
+ Hits          6185      6187    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jul 17, 2025
@mtrezza mtrezza added state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message and removed state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants