Increase Type Checking #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new directories to .gitignore for Dagster project storage, logs, history, and schedules. - Modify Makefile to support Windows environments and add new clean commands for Dagster and database. - Update pyproject.toml to change version to 0.8.0 and add new dependencies for FastAPI and SSE-Starlette. - Refactor type hints across multiple files to use modern syntax and improve consistency. - Enhance console and event handling in dagster_sqlmesh for better logging and event management. - Clean up imports and ensure proper typing throughout the codebase. - Update sample project definitions for compatibility with new changes.
- Update type hints to use modern syntax throughout the file. - Clean up and reorganize import statements for better clarity. - Enhance function signatures with appropriate return types. - Ensure consistency in typing for fixtures and context classes.
- Unified command definitions for Python, SQLMESH, and UV to streamline setup. - Removed Windows-specific command handling for a cleaner and more consistent configuration. - Simplified activation and deactivation commands for the virtual environment.
- Simplified assertion statements in the test_restating_models function for better clarity. - Enhanced readability by formatting assertions with inline messages. - Maintained existing test logic and functionality.
ravenac95
reviewed
Mar 24, 2025
| rm -rf sample/dagster_project/storage sample/dagster_project/logs sample/dagster_project/history | ||
|
|
||
| clean-db: | ||
| $(PYTHON_CMD) -c "import duckdb; conn = duckdb.connect('db.db'); [conn.execute(cmd[0]) for cmd in conn.execute(\"\"\"SELECT 'DROP TABLE ' || table_schema || '.' || table_name || ' CASCADE;' as drop_cmd FROM information_schema.tables WHERE table_schema != 'sources' AND table_schema != 'information_schema' AND table_type = 'BASE TABLE'\"\"\").fetchall()]; [conn.execute(cmd[0]) for cmd in conn.execute(\"\"\"SELECT 'DROP VIEW ' || table_schema || '.' || table_name || ' CASCADE;' as drop_cmd FROM information_schema.tables WHERE table_schema != 'sources' AND table_schema != 'information_schema' AND table_type = 'VIEW'\"\"\").fetchall()]; conn.close()" |
There was a problem hiding this comment.
Hrm, I'd prefer if this was just a python script we called but I'll accept this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (AI-Generated)
This PR introduces type hint improvements, code cleanup, and enhanced development tooling. The changes focus on modernizing type hints, improving code quality, and adding new development commands.
Key Changes
Modernized type hints across the codebase to use Python 3.12 syntax
Optional[T]withT | NoneUnion[T1, T2]withT1 | T2Enhanced development tooling
clean-db: Cleans database tables while preserving source tablessqlmesh-planandsqlmesh-run: Direct SQLMesh commandsclean-dev: Combined command for database and Dagster cleanupExtended .gitignore
storage/logs/history/schedules/Implementation Details
substin MakefileThe changes are primarily focused on maintainability and developer experience, with no functional changes to the core logic.