Poetry --> UV (+ Makefile Added) #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change command in .lintstagedrc from 'poetry run ruff' to 'uv run ruff' - Migrate from [tool.poetry] to [project] section in pyproject.toml - Update authors and license format in pyproject.toml - Add dependencies under [project] and [project.optional-dependencies] sections - Switch build system from poetry to hatchling
- Deleted the poetry.lock file as part of the transition to a new dependency management approach.
- Removed the clean-dagster target to streamline the dagster-dev command. - Updated the dagster-dev command to remove the explicit workspace.yaml path, allowing for default behavior.
- Replaced Poetry setup with actions/setup-python for Python installation. - Added installation step for uv and updated commands to use uv for running checks and tests. - Streamlined the CI process by integrating uv for dependency synchronization and execution of tasks.
- Added `pyright` command to Makefile for type checking. - Updated `pyright` script in package.json to use the correct Python path. - Revised README to reflect the new Make commands for initializing and upgrading dependencies. - Simplified instructions for running tests and the sample dagster project using Make commands.
ravenac95
reviewed
Mar 13, 2025
ravenac95
reviewed
Mar 13, 2025
ravenac95
reviewed
Mar 13, 2025
Co-authored-by: Reuven Gonzales <reuven.v.gonzales@gmail.com>
Co-authored-by: Reuven Gonzales <reuven.v.gonzales@gmail.com>
- Removed OS-specific checks for Windows in the Makefile. - Unified Python, SQLMESH, and UV command definitions for a cleaner setup. - Simplified activation and deactivation commands for the virtual environment.
- Added Pyright exclusion patterns in pyproject.toml to ignore specific directories. - Introduced a new method `show_linter_violations` in EventConsole to handle and publish linting violations. - Reorganized imports in console.py for better clarity and consistency.
|
@ravenac95 managed to fix the pyright test issue I think (and get pyright to sync up with my extension as well so it's easier to see the errors in the UI compared to before - it looks like it is consistent now). I also adjusted the pyright command to use UV more plainly so that it doesn't require shell commands |
|
Thanks so much @duragdatadude looks good. Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.