Skip to content

feat: support tags in sqlmesh models #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dagster_sqlmesh/controller/dagster.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def to_asset_outs(
if not model:
# If no model is returned this seems to be an asset dependency
continue
asset_out = translator.get_asset_key_from_model(
asset_key = translator.get_asset_key_from_model(
context,
model,
)
Expand All @@ -43,6 +43,8 @@ def to_asset_outs(
for dep in deps
]
internal_asset_deps: t.Set[AssetKey] = set()
asset_tags = translator.get_tags(context, model)

for dep in model_deps:
if dep.model:
internal_asset_deps.add(
Expand All @@ -55,7 +57,9 @@ def to_asset_outs(
# create an external dep
depsMap[table.name] = AssetDep(key)
model_key = sqlmesh_model_name_to_key(model.name)
output.outs[model_key] = AssetOut(key=asset_out, is_required=False)
output.outs[model_key] = AssetOut(
key=asset_key, tags=asset_tags, is_required=False
)
output.internal_asset_deps[model_key] = internal_asset_deps

output.deps = list(depsMap.values())
Expand Down
22 changes: 9 additions & 13 deletions dagster_sqlmesh/translator.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import typing as t
import sqlglot
from sqlglot import exp
from sqlmesh.core.context import Context
Expand All @@ -9,27 +10,22 @@ class SQLMeshDagsterTranslator:
"""Translates sqlmesh objects for dagster"""

def get_asset_key_from_model(self, context: Context, model: Model) -> AssetKey:
"""Given the sqlmesh context and a model return the asset key"""
return AssetKey(model.view_name)

def get_asset_key_fqn(self, context: Context, fqn: str) -> AssetKey:
"""Given the sqlmesh context and a fqn of a model return an asset key"""
table = self.get_fqn_to_table(context, fqn)
return AssetKey(table.name)

def get_fqn_to_table(self, context: Context, fqn: str) -> exp.Table:
dialect = self.get_context_dialect(context)
"""Given the sqlmesh context and a fqn return the table"""
dialect = self._get_context_dialect(context)
return sqlglot.to_table(fqn, dialect=dialect)

def get_context_dialect(self, context: Context) -> str:
def _get_context_dialect(self, context: Context) -> str:
return context.engine_adapter.dialect

# def get_asset_deps(
# self, context: Context, model: Model, deps: List[SQLMeshModelDep]
# ) -> List[AssetKey]:
# asset_keys: List[AssetKey] = []
# for dep in deps:
# if dep.model:
# asset_keys.append(AssetKey(dep.model.view_name))
# else:
# parsed_fqn = dep.parse_fqn()
# asset_keys.append(AssetKey([parsed_fqn.view_name]))
# return asset_keys
def get_tags(self, context: Context, model: Model) -> t.Dict[str, str]:
"""Given the sqlmesh context and a model return the tags for that model"""
return {k: "true" for k in model.tags}
4 changes: 4 additions & 0 deletions sample/sqlmesh_project/models/marts/full_model.sql
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ MODEL (
cron '@daily',
grain item_id,
audits (assert_positive_order_ids),
tags (
"mart",
"full",
)
);

SELECT
Expand Down
6 changes: 5 additions & 1 deletion sample/sqlmesh_project/models/staging/staging_model_1.sql
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ MODEL (
),
start '2020-01-01',
cron '@daily',
grain (id, event_date)
grain (id, event_date),
tags (
"staging",
"incremental"
)
);

SELECT
Expand Down