Skip to content

FM2-429: Support for instance-level $everything operation Encounters in R3 #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Medhavi-16
Copy link
Contributor

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/FM2-429

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (086a7d2) to head (6882491).
Report is 278 commits behind head on master.

Files with missing lines Patch % Lines
...r2/providers/r3/EncounterFhirResourceProvider.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #368      +/-   ##
============================================
+ Coverage     80.75%   80.78%   +0.03%     
- Complexity     2247     2257      +10     
============================================
  Files           205      205              
  Lines          6027     6041      +14     
  Branches        707      708       +1     
============================================
+ Hits           4867     4880      +13     
  Misses          741      741              
- Partials        419      420       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Medhavi-16
Copy link
Contributor Author

@ibacher @varung-31 PTAL.

assertThat(results, nullValue());
}

private List<IBaseResource> getAllResources(IBundleProvider result) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Medhavi-16 do you really need to add this method under the tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Medhavi-16 I'm also wondering this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HerbertYiga @ibacher I'm sorry, I've been M.I.A.. Yeah, we don't need this method. I'll remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibacher PTAL.

@theanandankit
Copy link
Contributor

LGTM @ibacher can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants