Skip to content

Make mypy run on more CI matrix, bring back "True-True" #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Make mypy run on more CI matrix, bring back "True-True" #2087

wants to merge 10 commits into from

Conversation

mattwthompson
Copy link
Member

@mattwthompson mattwthompson commented Jul 14, 2025 •
edited
Loading

Trying to resolve #2092

CI is not running RDKit=True OpenEye=True cases. I probably broke this, so I'm trying to fix it here.

@mattwthompson mattwthompson mentioned this pull request Jul 14, 2025
Open
4 tasks
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (158117d) to head (b7c6c84).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattwthompson mattwthompson changed the title Make sure CI runs "True-True" case Make mypy run on more CI matrix, bring back "True-True" Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-wags j-wags Awaiting requested review from j-wags j-wags will be requested when the pull request is marked ready for review j-wags is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"True-True" CI not running
1 participant
@mattwthompson