build: remove unused reactifex packages #1274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
=======================================
Coverage 81.17% 81.17%
=======================================
Files 51 51
Lines 834 834
Branches 240 231 -9
=======================================
Hits 677 677
Misses 150 150
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
20 tasks
arbrandes
approved these changes
Sep 26, 2025
Remove reactifex and @edx/reactifex packages from devDependencies as they are no longer needed. Translation extraction functionality has been verified to work correctly without these dependencies. Co-Authored-By: Claude <noreply@anthropic.com>
brian-smith-tcril
force-pushed
the
feanil/remove-reactifex-packages
branch
from
0b02be7 to
d2d5dcc
Compare
|
@arbrandes the problem you noticed in #1262 (comment) is showing up here too, it's because of branch protection rules looking specifically for "tests (thing)" instead of "tests (thing, version)" I'm happy to update the branch protection rules here. For the other repos I did it before landing the "add 24 to the matrix" PRs and updated the rules to look for "tests (thing, 20)" Considering #1266 has already landed, which version should I update this one to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reactifex and @edx/reactifex packages from devDependencies as they are no longer
needed. Translation extraction functionality has been verified to work
correctly without these dependencies.
Co-Authored-By: Claude noreply@anthropic.com