-
Notifications
You must be signed in to change notification settings - Fork 89
fix: matching styles for report/delete post buttons #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: matching styles for report/delete post buttons #794
Conversation
Thanks for the pull request, @bydawen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 167 167
Lines 3691 3691
Branches 991 991
=======================================
Hits 3483 3483
Misses 193 193
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
392d2fa
to
7175a47
Compare
7175a47
to
b081c05
Compare
src/discussions/posts/post/Post.jsx
Outdated
onClose={hideReportConfirmation} | ||
confirmAction={handleReportConfirmation} | ||
confirmButtonVariant="danger" | ||
confirmButtonVariant="primary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit]: Do we need to specify the primary variant if we have it by default for the confirmButtonVariant prop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit]: Do we need to specify the primary variant if we have it by default for the confirmButtonVariant prop?
Yes, you’re right — thank you! I’ve removed this line since it’s already set in defaultProps.
I do think there’s some value in keeping it explicitly for clarity (so you immediately see which variant is used without checking defaults), but that’s a subjective opinion.
b081c05
to
2a8f442
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this locally, but the code looks good.
Sandbox deployment failed 💥 |
Sandbox deployment failed 💥 |
Sandbox deployment successful 🚀 |
2a8f442
to
e64e71a
Compare
Sandbox deployment successful 🚀 |
When choose report or delete post, looks like confirm and delete buttons have mismatched style:


It seems that Confirm must have


primary
variant, and Deletedanger
variant, not vice versa, fixed variants: