Skip to content

Conversation

bydawen
Copy link
Contributor

@bydawen bydawen commented Jul 28, 2025

When choose report or delete post, looks like confirm and delete buttons have mismatched style:
Screenshot 2025-07-28 at 12 18 06
Screenshot 2025-07-28 at 12 18 44

It seems that Confirm must have primary variant, and Delete danger variant, not vice versa, fixed variants:
Screenshot 2025-07-28 at 12 22 16
Screenshot 2025-07-28 at 12 22 38

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 28, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @bydawen!

This repository is currently maintained by @openedx/edx-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.36%. Comparing base (3e1c953) to head (e64e71a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #794   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files         167      167           
  Lines        3691     3691           
  Branches      991      991           
=======================================
  Hits         3483     3483           
  Misses        193      193           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 28, 2025
@ihor-romaniuk ihor-romaniuk force-pushed the fix/mixed-up-report-delete-buttons-style branch from 392d2fa to 7175a47 Compare August 4, 2025 12:06
@ihor-romaniuk ihor-romaniuk force-pushed the fix/mixed-up-report-delete-buttons-style branch from 7175a47 to b081c05 Compare August 28, 2025 12:22
onClose={hideReportConfirmation}
confirmAction={handleReportConfirmation}
confirmButtonVariant="danger"
confirmButtonVariant="primary"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]: Do we need to specify the primary variant if we have it by default for the confirmButtonVariant prop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]: Do we need to specify the primary variant if we have it by default for the confirmButtonVariant prop?

Yes, you’re right — thank you! I’ve removed this line since it’s already set in defaultProps.
I do think there’s some value in keeping it explicitly for clarity (so you immediately see which variant is used without checking defaults), but that’s a subjective opinion.

@bydawen bydawen force-pushed the fix/mixed-up-report-delete-buttons-style branch from b081c05 to 2a8f442 Compare September 5, 2025 08:04
@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Sep 5, 2025
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this locally, but the code looks good.

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@bydawen bydawen force-pushed the fix/mixed-up-report-delete-buttons-style branch from 2a8f442 to e64e71a Compare September 11, 2025 09:39
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

5 participants