Skip to content

Fix _export_batches docstring to remove incorrect "threshold" reference #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

DanielHashmi
Copy link
Contributor

The docstring incorrectly mentioned "below a certain threshold" but the actual implementation drains the queue completely regardless of any threshold.

@seratch seratch added documentation Improvements or additions to documentation feature:tracing labels Jul 28, 2025
@seratch seratch merged commit aba88c7 into openai:main Jul 28, 2025
7 checks passed
@DanielHashmi DanielHashmi deleted the patch-2 branch July 29, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature:tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants