examples: minor tweak on llm_as_a_judge example #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduced `max_attempts` counter to prevent infinite judging loops (defaults to 5) * Added trailing spaces between adjacent string literals for clearer agent prompts * Inserted missing “the” in evaluator instructions for grammatical accuracy
seratch
requested changes
Jul 28, 2025
| @@ -30,9 +30,9 @@ class EvaluationFeedback: | |||
| evaluator = Agent[None]( | |||
| name="evaluator", | |||
| instructions=( | |||
| "You evaluate a story outline and decide if it's good enough." | |||
| "If it's not good enough, you provide feedback on what needs to be improved." | |||
| "Never give it a pass on the first try. After 5 attempts, you can give it a pass if story outline is good enough - do not go for perfection" | |||
There was a problem hiding this comment.
the instructions allow running 5+ times, so the changes in this PR are inconsistent. if you remove the max_attempts etc., we are happy to merge other changes.
There was a problem hiding this comment.
Thanks for pointing that out. The max_attempts logic has been removed, and only the instruction formatting fixes are kept.
seratch
reviewed
Jul 29, 2025
| @@ -46,6 +46,8 @@ async def main() -> None: | |||
|
|
|||
| # We'll run the entire workflow in a single trace | |||
| with trace("LLM as a judge"): | |||
| max_attempts = 5 | |||
There was a problem hiding this comment.
as i mentioned above, please remove this additional logic, which is not necessary
There was a problem hiding this comment.
Apologies, I clicked the review request by mistake before reverting the changes.
* Reverted the `max_attempts` safeguard logic to restore the intended behavior of the LLM-as-a-judge pattern. The evaluator instructions use the phrase “After 5 attempts, you *can* give it a pass,” indicating discretion rather than a strict limit. * Retained fixes to instruction string formatting to avoid run-together text (e.g., “input.If there” → “input. If there”). * Corrected a minor grammatical issue by adding “the” before “story outline” for proper English usage.
seratch
approved these changes
Jul 29, 2025
seratch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.