Fix OTLP MetricExporter deadlock by switching to tokio::Mutex #3107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTLP Tonic MetricExporter was using
std::sync::Mutex
to protect the inner client, but the lock was being held across await points in the export method. This could cause deadlocks becausestd::Mutex
is not async-safe and blocks the entire thread when contended.Problem
The issue occurs when multiple concurrent export operations compete for the mutex, especially if the interceptor logic involves any blocking operations.
Solution
Switch to
tokio::sync::Mutex
and use the async lock pattern already established by the LogsExporter:Changes
std::sync::Mutex
totokio::sync::Mutex
.lock().await
instead of.lock()
Verification
Fixes #2802.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.