-
Notifications
You must be signed in to change notification settings - Fork 745
[carriers] add env carrier #4609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adrielp
wants to merge
5
commits into
open-telemetry:main
Choose a base branch
from
adrielp:env-carrier-proto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pellared
reviewed
Jun 3, 2025
4 tasks
github-merge-queue bot
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Jul 8, 2025
## Changes Adds supplementary guidance around the behaviors the SDKs should look to implement. * [x] Related issues [#4470](#4470) & #4484 * [x] Related [OTEP 0258](https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/0258-env-context-baggage-carriers.md) * [x] Links to the prototypes (when adding or changing features) - [Go](open-telemetry/opentelemetry-go#6778) - [Python](open-telemetry/opentelemetry-python#4609) * [x] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
259041f
to
ccdb1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a prototype for the environment variable carrier, specifically decorating Getter and Setter instead of creating a dedicated propagator. The comes from the conversations within the environment variable context propagation specification pull request.
There's a corresponding thread in Slack around this topic.
The example use of the Getter portion of this prototype can be found in this gist.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The Getter was tested by using the prototype in a real environment. Unit tests need to be added after conversation around this prototype.
Does This PR Require a Contrib Repo Change?
Checklist: