Allow account linking via a code #8358
Open
+496
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-jukic
requested review from
hpeebles,
megrogan and
julianjelfs
as code owners
ivan-jukic
commented
Jul 16, 2025
|
--- Adds a feature to create account linking codes. These will be used with native apps to link existing accounts to the passkeys created on these devices.
ivan-jukic
force-pushed
the
native/connect-with-otp
branch
from
a7ee110 to
254e6c6
Compare
ivan-jukic
commented
Jul 17, 2025
| // | ||
| // ---- Initialise new identity to link ---- | ||
| // | ||
| let (new_principal, new_pub_key) = random_delegated_principal(canister_ids.sign_in_with_email); |
There was a problem hiding this comment.
I'm slightly confused about the requirements for the canister id here. It's later validated on the backend, and it must be from expected set of canister ids. Could anyone shed a bit of light on this?
I've not used Webauthn key here, would that yield a different result if I had used a different canister id here?
ivan-jukic
commented
Jul 17, 2025
| @@ -49,6 +49,6 @@ function cleanup() { | |||
|
|
|||
| trap cleanup EXIT | |||
|
|
|||
| cargo test --package integration_tests $TESTNAME -- --test-threads $TEST_THREADS || exit 1 | |||
| cargo test --package integration_tests $TESTNAME -- --nocapture --test-threads $TEST_THREADS || exit 1 | |||
There was a problem hiding this comment.
Could we keep this 🤔 ? I find it useful sometimes if I want to println! something in the test... Is there a different way you'd recommend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature to create account linking codes. These will be used with native apps to link existing accounts to the passkeys created on these devices.