feat: allow use of scoped containers #21
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
By default, TypeORM only supports a global container[0], which is referenced whenever you call
getManager()
.This PR contains my potential solution but requires your services have a public
container
property exposed so the@Transactional
decorator can access it, and an activeConnectionManager
instance in the container.Is there a better way of doing this? Is this feature something you'd be interested in merging? Please let me know your thoughts -- I'm sure there must be a cleaner way of achieving this!
Thanks!
[0] https://github.com/typeorm/typeorm/blob/master/src/container.ts