msys2 path patches to make git functions work at least #3495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch assumes that
plenary.nvim
has the changes I made in the corresponded PR. At least forplenary.utils
module and path conversions in internal logic.As stated in the
plenary
's PR the msys2 integration is very fragile so I left all my comments and test notifies for further debugging.Description
I want to make Plenary and Telescope compliant with msys2 (and windows indirectly).
The good looking changes can be hard to achieve cause msys2 returns posix-style paths but can use Windows-style
and in the same time neovim from
clang64
repo returns windows-style paths but can not use posix-style.The main idea would be a complete dependence on Plenary/Nvim path work.
But now I want to share how the fix-up changes look like in the current version (w/o breaking changes).
The fixes are mainly for git-related functions. I wanted to have it working and I achieved that with dirty changes.
Type of change
How Has This Been Tested?
The issue is more likely to be long-term, so I will leave the reproduction steps for later
if someone ever wants to reproduce it and doesn't have msys2+nvim configured yet.
Configuration:
5.9 (x86_64-pc-msys)
(maybe causes {} expansion)GNU bash, version 5.2.37(2)-release (x86_64-pc-cygwin)
(setted as nvim shell)NVIM v0.11.1 from msys2's clang64 repo
Windows 10 Pro 22H2 19045.5854
Checklist: