feat(diff): add support for mercurial #2022
Open
+133
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the final idea is to add support for `mercurial`, that has a similar structure to git's. Parameterizing these functions makes the addition of mercurial trivial. The patch renames those functions as `s/git_/dvcs_/` to reflect their more generic nature.
so that next time we try to use `dvcs_cache`, we can start from scratch. This is important when other `gen_sources` are using `dvcs_cache` as well.
This reverts commit 0270aa8.
in particular, this patch fixes: 1. `s/watch_index_opts/opts/` 2. `s/dvcs/vcs/` 3. `s/hg/mercurial/` 4. Format with `stylua`
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mercurial follows a very similar patter to Git: (1) It has an index pointing to the latest changes in the repo (
dirstate) and (2) we are able tocatthe file content of files in the repository.This patch does
threetwo things:Formatdiff.luawithlua_ls. If this is not ok, I can add a revert of it.index, command to find the repo directory, and command to get files in the repo. Methods are renameds/git_/dvcs_/to make it clear that they are more generic now.Originally pr #1878.