-
Notifications
You must be signed in to change notification settings - Fork 883
fix(FileUpload): dataTypes and reactivity issues #4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3
Are you sure you want to change the base?
Conversation
Changing the props would lead to no updates which made the documentation example broken.
multiple, | ||
accept: unref(optionsComputed.value.accept), | ||
multiple: optionsComputed.value.multiple, | ||
input: unref(inputRef), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be refactored to be outside of onMounted
which would simplify things, but there seems to be some kind of reactivity issue with the inputRef
inside of useFileDialog, because it should be possible to do input: inputRef
and then there is no need for the onMounted
hook, but it doesn't work, but in minimal repro it does. Perhaps a bug in VueUse?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's a VueUse bug, probably: vueuse/vueuse#4867
Hey @J-Michalek! Thanks for the improvements but I find it a bit hard to review, if you have time could you split the two fixes into two PRs? |
@benjamincanac The first PR (and the more important one) is here: #4671 it fixes the issue with the |
@J-Michalek I'll try to review asap but between holidays and v4 work my schedule is tight π¬ |
π Linked issue
Resolves: #4638
β Type of change
π Description
I've added support for data types such as
image/*
and fixed reactivity issues with options passed intouseFileUpload
.π Checklist