Skip to content

Conversation

J-Michalek
Copy link
Contributor

@J-Michalek J-Michalek commented Aug 1, 2025

πŸ”— Linked issue

Resolves: #4638

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I've added support for data types such as image/* and fixed reactivity issues with options passed into useFileUpload.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

multiple,
accept: unref(optionsComputed.value.accept),
multiple: optionsComputed.value.multiple,
input: unref(inputRef),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be refactored to be outside of onMounted which would simplify things, but there seems to be some kind of reactivity issue with the inputRef inside of useFileDialog, because it should be possible to do input: inputRef and then there is no need for the onMounted hook, but it doesn't work, but in minimal repro it does. Perhaps a bug in VueUse?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's a VueUse bug, probably: vueuse/vueuse#4867

@benjamincanac
Copy link
Member

Hey @J-Michalek! Thanks for the improvements but I find it a bit hard to review, if you have time could you split the two fixes into two PRs?

@J-Michalek
Copy link
Contributor Author

@benjamincanac The first PR (and the more important one) is here: #4671 it fixes the issue with the accept prop not working when wildcard values are used.

@benjamincanac
Copy link
Member

@J-Michalek I'll try to review asap but between holidays and v4 work my schedule is tight 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No dropzone in FileUpload
2 participants