[FIX] defer check of file existence to workflow build stage #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 84.13% 84.08% -0.06%
==========================================
Files 30 30
Lines 2874 2877 +3
Branches 380 382 +2
==========================================
+ Hits 2418 2419 +1
- Misses 381 382 +1
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bpinsard
force-pushed
the
relax_symlink_estimators
branch
from
51bf2c0 to
a89c5ff
Compare
bpinsard
force-pushed
the
relax_symlink_estimators
branch
from
a89c5ff to
8367ff3
Compare
effigies
approved these changes
Dec 12, 2025
Member
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
LGTM. Thanks for looking into this, and apologies for letting it fall off the radar.
Have you tested this? Would it help to have an fMRIPrep image to test with? This can be backported trivially, so we can target pretty much any fMRIPrep series.
Contributor
Author
|
I am currently testing it on one of our dataset, patching a container with the file. It builds the workflow so it seems to work (though I have other unrelated issues with pre-computed derivatives). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #400, that is still a blocker when parallelizing session processing with datalad.