-
Notifications
You must be signed in to change notification settings - Fork 101
NGINX App Protect OTel syslog processor #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devbgv
wants to merge
10
commits into
nginx:main
Choose a base branch
from
devbgv:bgv/nim-nap-otel-log-parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
c3c63df
to
5f92180
Compare
0139f27
to
e8085c2
Compare
craigell
approved these changes
Sep 22, 2025
dhurley
reviewed
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good just have a few additional comments.
- Could we actually rename the processor to
securityviolationsprocessor
?syslogprocessor
seems too generic since it wont be able to be used for other syslog messages that have a different message format - Could we add benchmark tests as well similar to these ones? https://github.com/nginx/agent/blob/main/internal/collector/logsgzipprocessor/processor_benchmark_test.go
aphralG
approved these changes
Sep 24, 2025
sean-breen
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Pull requests for routine tasks
dependencies
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introduce a syslog log processor that parses RFC 3164‑formatted log lines and enriches them with structured attributes such as timestamp, hostname, app name, and severity.
Register the processor in internal/collector/factories so it can be used in the agent’s processing pipeline.
Add the github.com/leodido/go-syslog/v4 dependency and wire it into the build.
Provide unit tests that validate successful parsing and attribute extraction from sample syslog messages.
Checklist