Skip to content

Conversation

VladLazar
Copy link
Contributor

@VladLazar VladLazar commented Jul 23, 2025

This is a hadron port to support the Hadron flavour of JWT tokens (original PR is #179).
I recommend the reviewer reads the original cover letter.

On top of that I changed:

  • endpoint_storage now uses the common JWT utilities which know how to differentiate between neon and hadron jwt
  • a lot of wrangling in control_plane
  • parametrise auth tests to use both neon and hadron JWT

Copy link

github-actions bot commented Jul 23, 2025

9174 tests run: 8520 passed, 0 failed, 654 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 34.7% (8847 of 25493 functions)
  • lines: 45.7% (71730 of 156847 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a1cc1f3 at 2025-07-31T11:39:13.507Z :recycle:

@VladLazar VladLazar changed the title Vlad/hadron jwt chore: support hadron JWT set-up Jul 24, 2025
@erikgrinaker erikgrinaker self-requested a review July 24, 2025 12:48
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ignoring style/design issues to avoid code churn. Just skimmed test changes.

@VladLazar VladLazar marked this pull request as ready for review July 25, 2025 11:23
@VladLazar VladLazar requested review from a team as code owners July 25, 2025 11:23
@VladLazar VladLazar requested review from ephemeralsad, knizhnik and MMeent and removed request for knizhnik and MMeent July 25, 2025 11:23
@VladLazar VladLazar requested review from myrrc and removed request for ephemeralsad July 25, 2025 11:23
@MMeent
Copy link
Contributor

MMeent commented Jul 25, 2025

(original PR is #179).

I have some serious doubts about that.

@erikgrinaker
Copy link
Contributor

(original PR is #179).

I have some serious doubts about that.

In the internal Hadron repo.

Copy link
Contributor

@williamhuan-db williamhuan-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyeballed through all the changes, should be fine. Just some comments on the potential new conflicts this may create and see if we can reduce some.

@VladLazar VladLazar enabled auto-merge July 29, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants