-
Notifications
You must be signed in to change notification settings - Fork 779
chore: support hadron JWT set-up #12706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…g decoding keys from X509 certificates (#165)
9174 tests run: 8520 passed, 0 failed, 654 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a1cc1f3 at 2025-07-31T11:39:13.507Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ignoring style/design issues to avoid code churn. Just skimmed test changes.
I have some serious doubts about that. |
In the internal Hadron repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eyeballed through all the changes, should be fine. Just some comments on the potential new conflicts this may create and see if we can reduce some.
This is a hadron port to support the Hadron flavour of JWT tokens (original PR is #179).
I recommend the reviewer reads the original cover letter.
On top of that I changed:
endpoint_storage
now uses the common JWT utilities which know how to differentiate between neon and hadron jwtcontrol_plane