fix: store key-value pairs in the hashmap preserving the order of insertions #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
\n
while writing the vocabulary.The bug
Since we were using
BTreeMap
we saved and loaded the merging rules (pair and index) not following the order of insertions, causing the following errors while loading the model:The pairs are not found in the vocabulary since the order of the pairs during the saving and load was wrong.
To fix the issue, we need to use an
IndexMap
type from theindexmap crate
since the standardHashMap
in Rust does not maintain insertion order. The issue is not present in the Python version since, from Python 3.7, the built-indict
type maintains insertion order by default.