Skip to content

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Sep 26, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Update skeletons after tabs are restored.

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner September 26, 2025 12:32
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 38.68%

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

Client.app: Coverage: 37.31

File Coverage
BrowserViewController.swift 32.55% ⚠️

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

  • ✨ Change in file size: +3 lines

Generated by 🚫 Danger Swift against 5d86bf2


func tabManagerDidRestoreTabs(_ tabManager: TabManager) {
updateTabCountUsingTabManager(tabManager)
if isSwipingTabsEnabled, isToolbarRefactorEnabled, isDeeplinkOptimizationRefactorEnabled {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove the deeplink optimization refactor as it is turn down as experiment. I'm going to remove that experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants