Skip to content

Remove normalize addresses. #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove normalize addresses. #974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions engineapi/engineapi/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,18 +1378,13 @@ def add_scores(
leaderboard_id: uuid.UUID,
scores: List[Score],
overwrite: bool = False,
normalize_addresses: bool = True,
):
"""
Add scores to the leaderboard
"""

leaderboard_scores = []

normalizer_fn = Web3.toChecksumAddress
if not normalize_addresses:
normalizer_fn = lambda x: x # type: ignore

addresses = [score.address for score in scores]

if len(addresses) != len(set(addresses)):
Expand All @@ -1411,7 +1406,7 @@ def add_scores(
leaderboard_scores.append(
{
"leaderboard_id": leaderboard_id,
"address": normalizer_fn(score.address),
"address": score.address,
"score": score.score,
"points_data": score.points_data,
}
Expand Down
10 changes: 0 additions & 10 deletions engineapi/engineapi/routes/leaderboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,9 +477,6 @@ async def position(
window_size: int = Query(1, description="Amount of positions up and down."),
limit: int = Query(10),
offset: int = Query(0),
normalize_addresses: bool = Query(
True, description="Normalize addresses to checksum."
),
db_session: Session = Depends(db.yield_db_session),
) -> List[data.LeaderboardPosition]:
"""
Expand All @@ -499,9 +496,6 @@ async def position(
logger.error(f"Error while getting leaderboard: {e}")
raise EngineHTTPException(status_code=500, detail="Internal server error")

if normalize_addresses:
address = Web3.toChecksumAddress(address)

positions = actions.get_position(
db_session, leaderboard_id, address, window_size, limit, offset
)
Expand Down Expand Up @@ -608,9 +602,6 @@ async def leaderboard_push_scores(
False,
description="If enabled, this will delete all current scores and replace them with the new scores provided.",
),
normalize_addresses: bool = Query(
True, description="Normalize addresses to checksum."
),
db_session: Session = Depends(db.yield_db_session),
Authorization: str = AuthHeader,
) -> List[data.LeaderboardScore]:
Expand Down Expand Up @@ -641,7 +632,6 @@ async def leaderboard_push_scores(
leaderboard_id=leaderboard_id,
scores=scores,
overwrite=overwrite,
normalize_addresses=normalize_addresses,
)
except actions.DuplicateLeaderboardAddressError as e:
raise EngineHTTPException(
Expand Down