-
Notifications
You must be signed in to change notification settings - Fork 205
feat: Flex_cluster long-running operation improvements #3525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: CLOUDP-320243-dev-2.0.0
Are you sure you want to change the base?
Conversation
}) | ||
} | ||
|
||
func dataSourceOverridenFields() map[string]dsschema.Attribute { | ||
return map[string]dsschema.Attribute{ | ||
"delete_on_create_timeout": nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do as timeout, remove it by default in DataSourceSchemaFromResource
. Also in plural
@@ -221,6 +225,11 @@ func CreateFlexCluster(ctx context.Context, projectID, clusterName string, flexC | |||
return flexClusterResp, nil | |||
} | |||
|
|||
// TODO: keeping CreateFlexCluster to avoid changes in adv_cluster and running their acc tests while doing this PR, remove before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create CLOUDP to handle this before finishing epic. There's a task on advanced_cluster
"Change default value for delete_on_create_timeout to true and improve cleanup warning message." where we can do this
Reuse HandleCreateTimeout on TPF |
Description
Flex_cluster long-running operation improvements.
TODO:
conversion.CopyModel
as in TPF adv_cluster, e.g. heredelete_on_create_timeout
, make sure there are no plan changes with previous provider versions (e.g. don't set default values in the schema), but it has to behave like default is true if not set.TestAccNetworkNetworkPeering_timeouts
.Link to any related issue(s): CLOUDP-333401
Type of change:
Required Checklist:
Further comments