Skip to content

feat: Flex_cluster long-running operation improvements #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: CLOUDP-320243-dev-2.0.0
Choose a base branch
from

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Jul 24, 2025

Description

Flex_cluster long-running operation improvements.

TODO:

  • Data source failing because it's sharing resource model (TFModel and NewTFModel), should probably be split up and have TFModelDS without Timeouts, similar to TPF adv_cluster, and decide if Timeouts model setting can go inside NewTFModel. In this case, instead of implemening a NewTFModelDS func, it could use NewTFModel and leverage on conversion.CopyModel as in TPF adv_cluster, e.g. here
  • Use timeouts in Create, Read, Update
  • Implement logic for delete_on_create_timeout, make sure there are no plan changes with previous provider versions (e.g. don't set default values in the schema), but it has to behave like default is true if not set.
  • Add acc test, e.g. like TestAccNetworkNetworkPeering_timeouts.
  • Resolve TODO comments.

Link to any related issue(s): CLOUDP-333401

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

})
}

func dataSourceOverridenFields() map[string]dsschema.Attribute {
return map[string]dsschema.Attribute{
"delete_on_create_timeout": nil,
Copy link
Collaborator

@oarbusi oarbusi Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do as timeout, remove it by default in DataSourceSchemaFromResource. Also in plural

@@ -221,6 +225,11 @@ func CreateFlexCluster(ctx context.Context, projectID, clusterName string, flexC
return flexClusterResp, nil
}

// TODO: keeping CreateFlexCluster to avoid changes in adv_cluster and running their acc tests while doing this PR, remove before merging.
Copy link
Collaborator

@oarbusi oarbusi Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create CLOUDP to handle this before finishing epic. There's a task on advanced_cluster
"Change default value for delete_on_create_timeout to true and improve cleanup warning message." where we can do this

@oarbusi
Copy link
Collaborator

oarbusi commented Jul 24, 2025

Reuse HandleCreateTimeout on TPF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants