Skip to content

CLOUDP-334379/improve-promotion #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Conversation

andrpac
Copy link
Collaborator

@andrpac andrpac commented Jul 29, 2025

Summary

This makes the promotion step from a workflow_run to a workflow_call to avoid unnecessary gh api calls for scanning for the test-status of all tests.

Proof of Work

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@andrpac andrpac requested a review from a team as a code owner July 29, 2025 10:20
@andrpac andrpac force-pushed the CLOUDP-334379/improve-promotion branch from 327a38a to e3c90bc Compare July 29, 2025 11:10
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job!

@andrpac
Copy link
Collaborator Author

andrpac commented Jul 30, 2025

To be merged post-release

@helderjs helderjs merged commit 35d3cea into main Aug 5, 2025
23 checks passed
@helderjs helderjs deleted the CLOUDP-334379/improve-promotion branch August 5, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants