Skip to content

fix: pre-commit hook with unit tests #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

fix: pre-commit hook with unit tests #4072

merged 1 commit into from
Aug 1, 2025
+1 −1

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Aug 1, 2025 •
edited
Loading

Proposed changes

follow up from #4071, this fixes pre-commit hook

Jira ticket: CLOUDP-#

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review August 1, 2025 10:31
@fmenezes fmenezes requested a review from a team as a code owner August 1, 2025 10:31
@fmenezes fmenezes enabled auto-merge (squash) August 1, 2025 10:31
cveticm
cveticm approved these changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit b0af9fc into master Aug 1, 2025
27 checks passed
@fmenezes fmenezes deleted the fix_precommit_hook_unit branch August 1, 2025 10:44
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 57.953%. remained the same
when pulling dd02629 on fix_precommit_hook_unit
into ed04f12 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmenezes @coveralls @cveticm