CLOUDP-279514 Detect and block breaking changes #4064
Merged
+615
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, the new action will only work after we merge, given we need the new tool merged to use it in previous SHAs. |
blva
reviewed
Jul 30, 2025
| set -e | ||
| { | ||
| echo "JSON<<EOF" | ||
| go run tools/cmd/breakvalidator/main.go generate |
There was a problem hiding this comment.
Looks like it's failing, is it expected?
Run set -e
Error: stat tools/cmd/breakvalidator/main.go: no such file or directory
Error: Process completed with exit code 1.
Error: Unable to process file command 'output' successfully.
Error: Invalid value. Matching delimiter not found 'EOF'
There was a problem hiding this comment.
Yes, that is why I commented
Unfortunately, the new action will only work after we merge, given we need the new tool merged to use it in previous SHAs.
There was a problem hiding this comment.
oh! it's expected, sorry i missed it! continuing to review
|
Coverage Report 📈
|
|
tested in #4065 we see what is wrong on the task details |
blva
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Detect and block breaking changes
Jira ticket: CLOUDP-279514
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments