Skip to content

CLOUDP-333877: create stub for atlas cli commands streams workspaces and streams workspaces create #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2025

Conversation

Waybo26
Copy link
Collaborator

@Waybo26 Waybo26 commented Jul 28, 2025

Proposed changes

Layout framework for switching atlas cli command instances over to workspaces; starting with workspaces create.

Jira ticket: CLOUDP-333877

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

@Waybo26 Waybo26 requested a review from kpatel71716 July 28, 2025 22:02
Copy link
Collaborator

@kpatel71716 kpatel71716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! some small things from a first pass

Copy link
Contributor

Coverage Report 📉

Branch Commit Coverage
master d165a3f 25.9%
CLOUDP-333877 790b073 %
Difference -25.9%

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 65.017% (-0.08%) from 65.098%
when pulling ea66a4b on CLOUDP-333877
into e84041f on master.

Copy link
Collaborator

@kpatel71716 kpatel71716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we add a update the PR title + edit the description to this PR to indicate that this is laying the groundwork for the command rename but is not adding the command for usage yet?

@Waybo26 Waybo26 changed the title CLOUDP-333877: create streams workspaces atlas cli command + workspaces create CLOUDP-333877: create framework for atlas cli commands streams workspaces and streams workspaces create Jul 31, 2025
@Waybo26 Waybo26 marked this pull request as ready for review July 31, 2025 21:55
@Waybo26 Waybo26 requested a review from a team as a code owner July 31, 2025 21:55
@Waybo26 Waybo26 changed the title CLOUDP-333877: create framework for atlas cli commands streams workspaces and streams workspaces create CLOUDP-333877: create stub for atlas cli commands streams workspaces and streams workspaces create Jul 31, 2025
@Waybo26 Waybo26 merged commit fbf4387 into master Jul 31, 2025
26 of 27 checks passed
@Waybo26 Waybo26 deleted the CLOUDP-333877 branch July 31, 2025 22:03
@fmenezes
Copy link
Collaborator

fmenezes commented Aug 1, 2025

Unfortunately, this PR was merged without our team reviewing, code owners was not enforced (I've enabled it now).

I happen to notice there is no new API in this code, is the intention here to alias an existing command instead?

When are you introducing new e2e tests?

@Waybo26
Copy link
Collaborator Author

Waybo26 commented Aug 1, 2025

My apologies for not waiting for a review. I can revert the PR or address any issues in a follow-up ticket I'm working on to integrate atlas streams workspaces update into the same framework that this PR addresses.
The new e2e tests will be included when the api is updated to generate the new fields that will be called by the command atlas streams workspaces (the new fields being defaultTier and maxTierSize)

@kpatel71716
Copy link
Collaborator

I happen to notice there is no new API in this code, is the intention here to alias an existing command instead?

We are planning on renaming the command from instance to workspace but we went away from aliasing because we want to add functionality to only workspace so users switch to that command. For now we are just adding underlying logic because we don't want the new command to be available yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants