-
Notifications
You must be signed in to change notification settings - Fork 89
CLOUDP-333877: create stub for atlas cli commands streams workspaces and streams workspaces create #4057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work! some small things from a first pass
Coverage Report 📉
|
coverage: 65.017% (-0.08%) from 65.098% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can we add a update the PR title + edit the description to this PR to indicate that this is laying the groundwork for the command rename but is not adding the command for usage yet?
Unfortunately, this PR was merged without our team reviewing, code owners was not enforced (I've enabled it now). I happen to notice there is no new API in this code, is the intention here to alias an existing command instead? When are you introducing new e2e tests? |
My apologies for not waiting for a review. I can revert the PR or address any issues in a follow-up ticket I'm working on to integrate atlas streams workspaces update into the same framework that this PR addresses. |
We are planning on renaming the command from |
Proposed changes
Layout framework for switching atlas cli command instances over to workspaces; starting with workspaces create.
Jira ticket: CLOUDP-333877
Checklist
make fmt
and formatted my code