-
Notifications
You must be signed in to change notification settings - Fork 21
DOCSP-52058 CRUD app with Rocket title #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-52058 CRUD app with Rocket title #194
Conversation
✅ Deploy Preview for docs-rust ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-rust processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ 1 change
Tutorial: Create a CRUD Web App with Rocket | ||
=========================================== | ||
======================== | ||
CRUD Web App with Rocket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep tutorial:
at the beginning, like we've done for other tutorials adapted from dev center articles
CRUD Web App with Rocket | |
Tutorial: CRUD Web App with Rocket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Titles should be between 30-60 characters." Adding Tutorial would violate these boundaries and negate the purpose of cutting the title down. I wonder if adding "Tutorial:" is necessary to convey the purpose of the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing 34 characters for the title I suggested...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full title includes "Tutorial: CRUD Web App with Rocket - Rust Driver v3.2 - MongoDB Docs" according to the JIRA ticket, which would make it 68 characters.
(cherry picked from commit ca80ca6)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-52058
Staging Links
Self-Review Checklist