make DurationField store milliseconds instead of microseconds #62
Conversation
django_mongodb/operations.py
Outdated
| if value is not None: | ||
| # Multiplying value converts milliseconds stored in the database | ||
| # to microseconds expected by timedelta. | ||
| value = datetime.timedelta(0, 0, value * 1000) |
There was a problem hiding this comment.
If i am not mistaken, timedelta has the following parameters:
class datetime.timedelta(days=0, seconds=0, microseconds=0, milliseconds=0, minutes=0, hours=0, weeks=0)
Maybe we don't need the scalation if we just pass the valle to microseconds.
django_mongodb/fields/duration.py
Outdated
| """DurationField stores milliseconds rather than microseconds.""" | ||
| value = _get_db_prep_value(self, value, connection, prepared) | ||
| if connection.vendor == "mongodb" and value is not None: | ||
| value = int(Decimal(value) / 1000) |
There was a problem hiding this comment.
Why Decimal? Can't it be: int(value) // 1000 ?
| @@ -70,6 +70,9 @@ def value(self, compiler, connection): # noqa: ARG001 | |||
| elif isinstance(value, datetime.date): | |||
| # Turn dates into datetimes since BSON doesn't support dates. | |||
| value = datetime.datetime.combine(value, datetime.datetime.min.time()) | |||
| elif isinstance(value, datetime.timedelta): | |||
| # DurationField store milliseconds rather than microseconds. | |||
| value = value.total_seconds() * 1000 | |||
| return {"$literal": value} | |||
There was a problem hiding this comment.
🤔 I am wondering if (value / timedelta(milliseconds=1)).total_seconds() works?
There was a problem hiding this comment.
Yes, except that timedelta / timedelta gives a float, so no need for total_seconds(). Do you see an advantage to that version?
There was a problem hiding this comment.
Agree on no need of total_second I misunderstood the docs. https://docs.python.org/3/library/datetime.html#datetime.timedelta.total_seconds
But it recommended, by the docs, to use the division by time delta. I see no advantages, only the docs
timgraham
force-pushed
the
durationfield-store-millisecond
branch
2 times, most recently
from
3d97680 to
03b5e0c
Compare
timgraham
force-pushed
the
durationfield-store-millisecond
branch
from
03b5e0c to
2c87452
Compare
MongoDB's arithmetic operators like $add treat numbers are milliseconds.
timgraham
force-pushed
the
durationfield-store-millisecond
branch
from
2c87452 to
c769dcc
Compare
MongoDB's arithmetic operators like $add treat numbers are milliseconds.