-
Notifications
You must be signed in to change notification settings - Fork 7
APIBot: SDK update based on recent changes in Atlas API #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ctx context.Context | ||
ApiService CloudMigrationServiceApi | ||
groupId string | ||
liveMigrationRequest20240530 *LiveMigrationRequest20240530 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing impact of @blva changes! Thank you for the fix. I can confirm that we do have new fields right now
- (\*DiskBackupExportJob).GetComponents: changed from func() []DiskBackupBaseRestoreMember to func() []DiskBackupExportMember | ||
- (_DiskBackupExportJob).GetComponentsOk: changed from func() (_[]DiskBackupBaseRestoreMember, bool) to func() (\*[]DiskBackupExportMember, bool) | ||
- (\*DiskBackupExportJob).SetComponents: changed from func([]DiskBackupBaseRestoreMember) to func([]DiskBackupExportMember) | ||
- (*InvoicesApiService).ListInvoicesExecute: changed from func(ListInvoicesApiRequest) (*PaginatedApiInvoice, *net/http.Response, error) to func(ListInvoicesApiRequest) (*PaginatedApiInvoiceMetadata, \*net/http.Response, error) | ||
- (\*LiveMigrationRequest).GetDropEnabled: removed | ||
- (\*LiveMigrationRequest).GetDropEnabledOk: removed | ||
- (\*LiveMigrationRequest).SetDropEnabled: removed | ||
- AuthorizeCloudProviderAccessRoleApiParams.CloudProviderAccessAWSIAMRoleUpdateRequest: removed | ||
- CloudProviderAccessAWSIAMRoleRequest: removed | ||
- CloudProviderAccessAWSIAMRoleUpdateRequest: removed | ||
- CreateCloudProviderAccessRoleApiParams.CloudProviderAccessAWSIAMRoleRequest: removed | ||
- CreatePushMigrationApiParams.LiveMigrationRequest: removed | ||
- DiskBackupBaseRestoreMember: removed | ||
- DiskBackupExportJob.Components: changed from _[]DiskBackupBaseRestoreMember to _[]DiskBackupExportMember | ||
- InvoicesApi.ListInvoicesExecute: changed from func(ListInvoicesApiRequest) (*PaginatedApiInvoice, *net/http.Response, error) to func(ListInvoicesApiRequest) (*PaginatedApiInvoiceMetadata, *net/http.Response, error) | ||
- ListInvoicesApiRequest.Execute: changed from func() (*PaginatedApiInvoice, *net/http.Response, error) to func() (*PaginatedApiInvoiceMetadata, *net/http.Response, error) | ||
- LiveMigrationRequest.DropEnabled: removed | ||
- LiveMigrationRequest: removed | ||
- NewCloudProviderAccessAWSIAMRoleRequest: removed | ||
- NewCloudProviderAccessAWSIAMRoleRequestWithDefaults: removed | ||
- NewCloudProviderAccessAWSIAMRoleUpdateRequest: removed | ||
- NewCloudProviderAccessAWSIAMRoleUpdateRequestWithDefaults: removed | ||
- NewDiskBackupBaseRestoreMember: removed | ||
- NewDiskBackupBaseRestoreMemberWithDefaults: removed | ||
- NewLiveMigrationRequest: removed | ||
- NewLiveMigrationRequestWithDefaults: removed | ||
- ValidateMigrationApiParams.LiveMigrationRequest: removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be confirmed if changes do not affect Integrations.
There is a large amount of openapi corrections that remove field here.
CC @lantoli
- (\*DiskBackupExportJob).GetComponents: changed from func() []DiskBackupBaseRestoreMember to func() []DiskBackupExportMember | ||
- (_DiskBackupExportJob).GetComponentsOk: changed from func() (_[]DiskBackupBaseRestoreMember, bool) to func() (\*[]DiskBackupExportMember, bool) | ||
- (\*DiskBackupExportJob).SetComponents: changed from func([]DiskBackupBaseRestoreMember) to func([]DiskBackupExportMember) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec correction.
- (\*DiskBackupExportJob).GetComponents: changed from func() []DiskBackupBaseRestoreMember to func() []DiskBackupExportMember | ||
- (_DiskBackupExportJob).GetComponentsOk: changed from func() (_[]DiskBackupBaseRestoreMember, bool) to func() (\*[]DiskBackupExportMember, bool) | ||
- (\*DiskBackupExportJob).SetComponents: changed from func([]DiskBackupBaseRestoreMember) to func([]DiskBackupExportMember) | ||
- (*InvoicesApiService).ListInvoicesExecute: changed from func(ListInvoicesApiRequest) (*PaginatedApiInvoice, *net/http.Response, error) to func(ListInvoicesApiRequest) (*PaginatedApiInvoiceMetadata, \*net/http.Response, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec correction
- (\*LiveMigrationRequest).GetDropEnabled: removed | ||
- (\*LiveMigrationRequest).GetDropEnabledOk: removed | ||
- (\*LiveMigrationRequest).SetDropEnabled: removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual breaking change introduced in the new version.
No longer relevant.
- CloudProviderAccessAWSIAMRoleRequest: removed | ||
- CloudProviderAccessAWSIAMRoleUpdateRequest: removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Effects of revert when fix for the issue caused multiple fields to be brolen.
Original issue is still present. @AgustinBettati have reported it initially.
To be established if that is not a blocker for release.
- NewCloudProviderAccessAWSIAMRoleRequest: removed | ||
- NewCloudProviderAccessAWSIAMRoleRequestWithDefaults: removed | ||
- NewCloudProviderAccessAWSIAMRoleUpdateRequest: removed | ||
- NewCloudProviderAccessAWSIAMRoleUpdateRequestWithDefaults: removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
- InvoicesApi.ListInvoicesExecute: changed from func(ListInvoicesApiRequest) (*PaginatedApiInvoice, *net/http.Response, error) to func(ListInvoicesApiRequest) (*PaginatedApiInvoiceMetadata, *net/http.Response, error) | ||
- ListInvoicesApiRequest.Execute: changed from func() (*PaginatedApiInvoice, *net/http.Response, error) to func() (*PaginatedApiInvoiceMetadata, *net/http.Response, error) | ||
- LiveMigrationRequest.DropEnabled: removed | ||
- LiveMigrationRequest: removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Effects of model renames. Migration should be straightforward.
Generation process and new changes LGTM. I have flagged potential issues in breaking changes to validate in terraform. |
Doing in TF repo:
Still investigating if they are fixable |
There are quite a big changes in the response for AtlasSearchApi.GetAtlasSearchIndex.Execute() TF version, v20231115014:
This PR, v20240530002:
|
it looks like many fields are in the new attribute LatestDefinition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's ok for me to go on with this release, we'll probably create a ticket in our side to use this new search API. thx!
Automatic update for MongoDB Atlas Go Client based on OpenAPI changes.
PR contains autogenerated changes for the MongoDB Atlas client.
Automated checks
Important Details
Fixes should be applied to the OpenAPI file (openapi/atlas-api.yaml) or ./tools engine in a separate PR.
Manual Review Procedure
./releaser/breaking_changes/{release_version}.md
fileTroubleshooting
To skip release process after merge please revert changes from
version.go
file.Release can be triggered by restoring changes in version.go.