CLOUDP-332090/proper-pagination #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrpac
force-pushed
the
CLOUDP-332090/proper-pagination
branch
3 times, most recently
from
7f9bfb1 to
e30d613
Compare
josvazg
reviewed
Jul 23, 2025
josvazg
reviewed
Jul 23, 2025
josvazg
reviewed
Jul 23, 2025
josvazg
reviewed
Jul 23, 2025
andrpac
force-pushed
the
CLOUDP-332090/proper-pagination
branch
7 times, most recently
from
177b680 to
40ab4cc
Compare
|
Q: Is there a way to test identity providers? Reference manifest does not include any information about them? |
andrpac
force-pushed
the
CLOUDP-332090/proper-pagination
branch
5 times, most recently
from
42d1472 to
b93b80b
Compare
andrpac
force-pushed
the
CLOUDP-332090/proper-pagination
branch
from
b93b80b to
f754a9e
Compare
s-urbaniak
approved these changes
Jul 25, 2025
helderjs
approved these changes
Jul 25, 2025
josvazg
reviewed
Jul 28, 2025
josvazg
approved these changes
Jul 28, 2025
andrpac
force-pushed
the
CLOUDP-332090/proper-pagination
branch
from
f754a9e to
a9e35b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This represents a proper pagination fix that loads all of the pages with the store, unlike the previous version which only returned one page.
Jira ticket: CLOUDP-332090
Checklist
make fmtand formatted my codeFurther comments
Note as of now the fix is only for ipAcessList as a sample of what will happen with all of them.