Version filter #113
Draft
Version filter #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntantri
reviewed
Jan 25, 2021
| @@ -45,6 +47,7 @@ | |||
| CloudFoundryDeployerAutoConfiguration.class, | |||
| KubernetesAutoConfiguration.class | |||
| }) | |||
| @ComponentScan(basePackageClasses = {AppRegistrationDao.class}) | |||
There was a problem hiding this comment.
If this is the default server, then why would this not have a ComponentScan before?
There was a problem hiding this comment.
There is another class that has other annotations but when I ran the app it failed to start, adding this here made it work. Still checking this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes - spring-attic#4344
Added param to API to filter using version
Created DAO to use predicates to filter. This will avoid multiple repo methods and if-else conditions.