add discriminator value to models for type narrowing and correct serialisation #8077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludgy4
requested review from
joheredi,
timotheeguerin,
timovv,
qiaozha,
MaryGao,
xirzec,
bterlson,
markcowl,
witemple-msft,
chrisradek and
AlitzelMendez
as code owners
microsoft-github-policy-service
bot
added
the
emitter:client:js
|
@microsoft-github-policy-service agree |
microsoft-github-policy-service
bot
added
the
stale
|
Hi @@Kludgy4. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the |
|
Hi @Kludgy4, thanks for the PR! To get a clearer picture of the issue and proposed fix, would you mind providing the spec or an equivalent example that demonstrates the discriminated union scenario you’re fixing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beforehand the discriminator was not added to deserialised models which created errors in the generated code which expects the discriminator value.
Also when discriminated unions are serialised they should have the discriminator value in the transport layer.