fix(ControlCore): prevent cursor repositioning during mouse selection #19182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the cursor repositioning logic to check if a selection is in progress - Only reposition the cursor when the mouse is used for positioning, not during selection operations
lhecker
reviewed
Jul 28, 2025
| @@ -2071,7 +2071,11 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| } | |||
| else if (_settings->RepositionCursorWithMouse()) // This is also mode==Char && !shiftEnabled | |||
| { | |||
| _repositionCursorWithMouse(terminalPosition); | |||
| // Don't reposition cursor if this is part of a selection operation | |||
| if (!selectionNeedsToBeCopied) | |||
There was a problem hiding this comment.
You can merge this with the else-if above.
To me this change makes sense. What about you @zadjii-msft?
There was a problem hiding this comment.
I have pushed a commit to make code more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and Relevant Issues
#19181
Detailed Description of the Pull Request / Additional comments