Skip to content

fix: throw on locator.press with unknown key #36703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Jul 17, 2025

We were retrying indefinitely because Unknown key: wasn't marked as non-recoverable.
Closes #36697.

@Skn0tt Skn0tt self-assigned this Jul 17, 2025
@Skn0tt Skn0tt requested a review from yury-s July 17, 2025 10:05
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [legacy-reuse] › highlight-locators.spec.ts:25:5 › should work @vscode-extension

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

46761 passed, 926 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt Skn0tt requested a review from dgozman July 22, 2025 14:55
@agg23
Copy link
Contributor

agg23 commented Jul 22, 2025

Looks good

@Skn0tt Skn0tt merged commit 2733247 into microsoft:main Jul 23, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: locator.press should throw on invalid keys or map common aliases
3 participants